feat: add support of ydotool alongside with wtype - #1821
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough
ChangesPaste backend selection
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 69: Move the clipboard bullet about preferring ydotool over wtype from
the v26.7.4 section into ## Unreleased, creating or reusing its ### Changed
subsection as needed. Keep the existing wording and release sections otherwise
unchanged.
In `@Configs/.local/lib/hyde/globalcontrol.sh`:
- Around line 376-383: Update the paste-command selection around the ydotool
branch to verify that a usable ydotoold backend is available before choosing
ydotool. If ydotoold is unavailable or unconfigured, continue to the existing
wtype fallback; preserve the current ydotool and no-backend behavior when its
backend is usable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 669074ca-ebdc-40fe-9f13-610aef5ab556
📒 Files selected for processing (4)
CHANGELOG.mdConfigs/.local/lib/hyde/globalcontrol.shScripts/dots/deps.tomlScripts/pkg_extra.lst
|
BTW can you contrast the diff of wtype and ydotool? in the past ydotool was buggy and requires a service while wtype just works. Any pros and cons between them?. ( aside from the OR desc ) |
|
Pull Request
Description
This PR add feature to use
ydotoolwhenwtypeis not present in the system. It can be helpful for multi-layout keyboard users becausewtypebreaks waybar indication of selected language.Type of change
Checklist
@kRHYME7 I'm a little bit confused about adding changelog entry: should I create smth like
## v26.x.x | Future Releasein the head of theCHANGELOG.md?Summary by CodeRabbit
ydotoolwhen available and falling back towtype.ydotoolto the required package list and documented optional paste-tool entries.